PERF: Quick Shift Implementation (GH5609) #6672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1910,9 +1907,20 @@ def fillna(self, value, limit=None, inplace=False, downcast=None): | |||
| values = self.values if inplace else self.values.copy() | |||
| return [self.make_block(values.get_values(value), fill_value=value)] | |||
|
|
|||
| def shift(self, indexer, periods, axis=0): | |||
| """ shift the block by periods """ | |||
| @classmethod | |||
There was a problem hiding this comment.
just make this a function defined inside shift itself. if its truly reusable them move to core/common, but I don't think used anywhere else, so just move to inside.
There was a problem hiding this comment.
SparseDataFrame is using this shift_indexer. However I don't think it is reusable enough to move to core/common. I plan to revert back to original code. What do you think?
|
looks good.... if you feel comfortable squashing go ahead otherwise you can ping me when its green |
jreback
changed the title
Added to note release.rst Move shift_indexer into the shift function Removed function _shift_indexer all together. Passes tests sparse. remove unwanted comments
|
I have squashed my commits. |
|
looks good...ping me when green |
|
Good to go! |
jreback
added a commit
that referenced
this pull request
Mar 20, 2014
PERF: Quick Shift Implementation (GH5609)
|
@gouthambs thanks! next time will be easier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5609
Test code
Results