-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Visualization reorganization #7027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Visualization reorganization #7027
Conversation
I put all the random seeds in I expanded |
`Seaborn <https://github.com/mwaskom/seaborn>`__ | ||
------------------------------------------------ | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the line as long as the line above? (it is not needed in rst actually, but sphinx gives a warning about it, so this is an easy thing to avoid those warnings)
@TomAugspurger I added some comments. But really like it, good improvements! A more general question: is it needed to put a |
Thanks, I appreciate it. For the random seeding we get two benefits. If someone is following along with the docs they'll be able to reproduce a specific plot exactly (without having to plot everyone up to that point so that their seed is in the same place as the docs). Second, adding new plots that make calls to These are very minor benefits, but not too costly I think. The toughest part will be maintanance. |
OK, this should be about ready. I changed the organization a bit, but I think it flows better now. Basically now its:
Before we went from basics and mixed in a bit of styling. I think the old way of going into specifics like I'd like to get #6976 in, then I'll rebase on top of that and merge this. |
Ok. I rebased on top of master now that #6976 is merged, so this is ready. Let me know if you disagree with the new layout, and I'll change it back. |
looks good to me, @jorisvandenbossche maybe throw a click reference to the controlling plot options in the Basic Plot section / intro ? |
New layout seems good to me also.
|
I had a second top level section, but I removed it so that the main sidebar would only have one plotting item. I think I'll just change For splitting the |
This pie plot just updated, can you use the plurals (e.g. You can create pie plots.... )
|
I would make styling a top-level bullet |
@TomAugspurger I would go ahead and merge when you are ready... prob easier to comment after we see it built and can always do follows |
- add matplotlib to intersphinx - put random seeds in supress and note - use versionadded in more places - link to api on more methods - title case titles - reorganize hierarchy The new hierarchy is - Basic Plotting (line plots on Frame and Series) - Other Plots (bar, scatter, etc.) - Plot formatting DOC: add ecosystem note to top of visualization.rst DOC: use cubehelix, not jet fix line lengths on headers reorg hierarchy to basic, other, and styling Change matplotlib url
DOC: Visualization reorganization
Rendered version: http://pandas-docs.github.io/pandas-docs-travis/visualization.html |
|
maybe move those top 2 notes (random and ecosystem), to the end of the Basic Plotting section... |
looks good! |
Looking good! Thanks a lot |
keywords are passed alogn to the corresponding matplotlib function | ||
(:meth:`ax.plot() <matplotlib.axes.Axes.plot>`, | ||
:meth: `ax.bar() <matplotlib.axes.Axes.bar>`, | ||
:meth: `ax.scatter() <matplotlib.axes.Axes.scatter>`). These can be used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noticed, the spaces in the three lines above (in :meth:
... -> `:meth:`...
) causes this not to render well
Closes #6994
I still need to do one more read through. Happy to hear additional suggestions.