DOC: mention that stack/unstack implicicly sort #7937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| all(df.unstack().stack() == df.sort()) | ||
|
|
||
| while the above code will raise a ``TypeError`` if the call to ``sort`` is | ||
| removed. |
There was a problem hiding this comment.
the spaces before removed should be removed
|
Oops, done... by the way: maybe this info could go also/instead in the docs for the two methods, I'm not sure. |
|
Yes, I think you can add a note in the docstring. |
jreback
added a commit
that referenced
this pull request
Aug 5, 2014
DOC: mention that stack/unstack implicicly sort
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to discover what was causing this TypeError... I guess this can be useful to other people.
(Yes, I know there is a note somewhere warning users that some operations depend on the index being sorted, but maybe this is a sligthly different case, since the operations do work after all, the problem is they do something more than what is documented)