Calling qcut with too many duplicates now gives an informative error #9030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,6 +165,10 @@ def qcut(x, q, labels=None, retbins=False, precision=3): | |||
| else: | |||
| quantiles = q | |||
| bins = algos.quantile(x, quantiles) | |||
| if len(algos.unique(bins)) < len(bins): | |||
| bins_sorted = np.sort(bins, axis=None) | |||
There was a problem hiding this comment.
you can do this as a set operation (set(bins)-set(unique(bins)) once you know that you have too many bins
There was a problem hiding this comment.
That doesn't work. Say bins = [0,0,0,1,1,1]. We want [0,1]. (set(bins)-set(unique(bins)) gives set([]).
Something like it should, but I can't think of it at the moment.
jreback
added
Reshaping
|
|
pls move the release note to v0.16.0. and rebase. thxs |
| @@ -164,7 +164,7 @@ Bug Fixes | |||
| - Bug in ``merge`` where ``how='left'`` and ``sort=False`` would not preserve left frame order (:issue:`7331`) | |||
| - Fix: The font size was only set on x axis if vertical or the y axis if horizontal. (:issue:`8765`) | |||
| - Fixed division by 0 when reading big csv files in python 3 (:issue:`8621`) | |||
|
|
|||
| - Fixed an unclear error message in ``qcut`` when repeated values result in duplicate bin edges. | |||
|
pls move the release note to 0.16.0 and rebase |
|
closing pls reopen if/when updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7751.