-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Corrects to_html print spacing GH4987 #9285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
does this actually change the way the output looks? |
As far as I know it only strips off the leading/trailing spaces in the HTML data rows. Those spaces shouldn't be rendered by a browser? |
@jorisvandenbossche @cpcloud @TomAugspurger look ok? |
@clham can you add a release note? (put it under API changes section in whatsnew, just a single line and reference the underlying issue) |
@jreback, Should be good to go. I added a plain api section. Current version only |
@TomAugspurger @jorisvandenbossche any problem with this? |
Seems OK to me |
But I think this should not be listed in API changes, but can be considered as a bug fix. |
merged via ed45e6e thanks! |
Thanks a lot for this, I had some problems letting pandoc convert such html and was doing a |
Closes #4987
This is my first non-doc PR, so please bare with me. Is it worth my while to go through the tests and standarize all of the test HTML to all block-strings, or is the mix of individual lines/blocks ok?