Skip to content

ENH: Corrects to_html print spacing GH4987 #9285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

clham
Copy link
Contributor

@clham clham commented Jan 17, 2015

Closes #4987

This is my first non-doc PR, so please bare with me. Is it worth my while to go through the tests and standarize all of the test HTML to all block-strings, or is the mix of individual lines/blocks ok?

@jreback jreback added Blocker Blocking issue or pull request for an upcoming release IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string and removed Blocker Blocking issue or pull request for an upcoming release labels Jan 17, 2015
@jreback jreback added this to the 0.16.0 milestone Jan 17, 2015
@jreback
Copy link
Contributor

jreback commented Jan 17, 2015

does this actually change the way the output looks?

@clham
Copy link
Contributor Author

clham commented Jan 17, 2015

As far as I know it only strips off the leading/trailing spaces in the HTML data rows. Those spaces shouldn't be rendered by a browser?

@jreback
Copy link
Contributor

jreback commented Jan 18, 2015

@jreback
Copy link
Contributor

jreback commented Jan 18, 2015

@clham can you add a release note? (put it under API changes section in whatsnew, just a single line and reference the underlying issue)

@clham
Copy link
Contributor Author

clham commented Jan 20, 2015

@jreback, Should be good to go. I added a plain api section. Current version only
lists breakages.

@jreback
Copy link
Contributor

jreback commented Mar 5, 2015

@TomAugspurger @jorisvandenbossche any problem with this?

@jorisvandenbossche
Copy link
Member

Seems OK to me

@jorisvandenbossche
Copy link
Member

But I think this should not be listed in API changes, but can be considered as a bug fix.
And it needs a rebase.

@jreback
Copy link
Contributor

jreback commented Mar 6, 2015

merged via ed45e6e

thanks!

@jreback jreback closed this Mar 6, 2015
@jreback jreback mentioned this pull request Mar 6, 2015
@jankatins
Copy link
Contributor

Thanks a lot for this, I had some problems letting pandoc convert such html and was doing a re.sub(' +',' ', html)but after this it isn't nessesary anymore :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: to_html improvement
4 participants