Changed uin8 to uint8 in response to issue #9266 #9350
Conversation
|
Thanks, this needs:
|
jreback
added
IO CSV
|
This is my first PR attempt and I don't understand this error message. Did I do something wrong in the test function I added? |
| with open('test.txt','w') as f: | ||
| f.write( | ||
| """1421302964.213420 PRI=3 PGN=0xef00 DST=0x17 SRC=0x28 04 154 00 00 00 00 00 127 | ||
| 1421302964.226776 PRI=6 PGN=0xf002 SRC=0x47 243 00 00 255 247 00 00 71""" |
There was a problem hiding this comment.
I think the issue is that this line starts with extra whitespace, throwing off colspecs below.
|
@CoolRanch29 I rebase and push your branch up here. pls review and update this PR when you can I am not sure what you are trying to compare against here (e.g. what should the expected frame look like?) |
|
Okay, I added an expected frame to test again. The problem before is that pd.read_fwf wasn't working at all - an exception was thrown when trying to read the test case. I'm still concerned that in the resulting frame, the column 'dst' is of type 'object' when using read_fwf and of type 'float64' when created by DataFrame(). |
| @@ -209,4 +209,9 @@ Bug Fixes | |||
| - Fixed issue in the ``xlsxwriter`` engine where it added a default 'General' format to cells if no other format wass applied. This prevented other row or column formatting being applied. (:issue:`9167`) | |||
| - Fixes issue with ``index_col=False`` when ``usecols`` is also specified in ``read_csv``. (:issue:`9082`) | |||
| - Bug where ``wide_to_long`` would modify the input stubnames list (:issue:`9204`) | |||
| <<<<<<< HEAD | |||
|
|
|||
There was a problem hiding this comment.
needs fixing here (eliminate the merge lines)
|
whats new is now available for 0.16.1 5ebf521 |
|
can you rebase this? |
|
I'm pretty sure I just rebased. I'm sorry if this is causing a headache for you, I'm sure I'm doing some things stupidly. I've gotten a lot of benefit out of using pandas and so I'm trying to contribute but this is my first time contributing so I'm having to learn a lot about both the pandas code and github. |
| @@ -2984,6 +2984,28 @@ def test_variable_width_unicode(self): | |||
| tm.assert_frame_equal(expected, read_fwf(BytesIO(test.encode('utf8')), | |||
| header=None, encoding='utf8')) | |||
|
|
|||
| def test_convert_to_nd_arrays(self): | |||
| #GH 9266 | |||
| with open('test.txt','w') as f: | |||
There was a problem hiding this comment.
use
with tm.ensure_clean('test.txt') as path:
with open(path,'w') as f:
....
|
couple of style things. pls add a release note in v0.16.1 as well. |
The docstring listed 'method' before 'value' which is not consistent with the order of the arguments when calling the method.
Updated docs throughout DataFrame methods to mention that axis can be set to 'index' or 'column' instead of 0 or 1 which improves readability significantly.
closes #9266