Fix a typo #16

amaechler · 2016-03-31T21:07:06Z

Ready for review.

timphillips · 2016-03-31T21:24:42Z

lib/run.js

@@ -60,7 +60,7 @@ module.exports = function simpleJslint(options) {
        }

        if (!file.isBuffer()) {
-            var err = new gutil.PluginError(pluginName, "This plugin requires bufferred files", {});
+            var err = new gutil.PluginError(pluginName, "This plugin requires buffered files", {});


Perhaps we should include the name and path of the non-buffered file in this error message? It would have been easier to diagnose https://github.com/pandell/node-repo-init/pull/148 if this information had been included in the error.

@timphillips Great idea, let me add that.

jgoz · 2016-03-31T21:59:07Z

👍 good change

amaechler · 2016-03-31T22:01:12Z

@timphillips Addressed. Updated message shows:

[15:48:08] Error in plugin 'gulp-jslint-simple'
Message:
    This plugin requires buffered files (C:\Users\...\big.js).

timphillips · 2016-03-31T22:03:32Z

Thanks for the update. 👍 from me.

jgoz · 2016-03-31T22:09:47Z

But seriously, who adds .js to a folder name?

Fix a typo

03a7dbf

amaechler self-assigned this Mar 31, 2016

amaechler added the enhancement label Mar 31, 2016

timphillips reviewed Mar 31, 2016
View reviewed changes

Add file path to the error message

5e45385

amaechler force-pushed the fix-typo branch from 6cbc7b0 to 5e45385 Compare March 31, 2016 21:55

amaechler merged commit b3c994b into master Apr 1, 2016

amaechler deleted the fix-typo branch April 1, 2016 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix a typo #16

Fix a typo #16

amaechler commented Mar 31, 2016

timphillips Mar 31, 2016

amaechler Mar 31, 2016

jgoz commented Mar 31, 2016

amaechler commented Mar 31, 2016

timphillips commented Mar 31, 2016

jgoz commented Mar 31, 2016

Fix a typo #16

Fix a typo #16

Conversation

amaechler commented Mar 31, 2016

timphillips Mar 31, 2016

Choose a reason for hiding this comment

amaechler Mar 31, 2016

Choose a reason for hiding this comment

jgoz commented Mar 31, 2016

amaechler commented Mar 31, 2016

timphillips commented Mar 31, 2016

jgoz commented Mar 31, 2016