Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for blockdiag actdiag nwdiag packetdiag rackdiag seqdiag #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

priiduonu
Copy link

No description provided.

@tarleb
Copy link
Member

tarleb commented Apr 27, 2024

Thank you for the PR, and apologies for the late reply, I had to let my open source involvement rest for a while.

I'm still a bit on the fence about this PR. My rule-of-thumb on what code to include here is whether I'd be willing to maintain the code myself, and I'm not sure in this case. My preferred solution would be to have this in a separate repository, with instructions on how to use it as an engine via the package configuration option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants