-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update list-table #204
Update list-table #204
Conversation
Well, this is simply incredible. |
b53a5c9
to
d6ba68f
Compare
This is great, thank you! A heads-up: we are in the process of making tables a bit more user-friendly. E.g., we now have types and constructors Since you put significant time into working with tables, it would be great to hear your ideas on how to make the Lua interface better. Please feel free to open new issues if anything comes to mind. |
Hey :) I don't mind updating my filter when the new Pandoc version with these constructors is released, so you don't have to add backwards compatibility just for my filter.
I noticed something about I am actually not very familiar with Lua so I don't think I can say much about the API design. I think the formatting of the Lua API docs could be improved by making it more vertically compact (i.e. displaying parameter name and description next to each other). h2 and h3 look very similar ... maybe if h2 were bold they were easier to spot and could help with orientation. |
Minor: this failed to produce any output on pandoc 2.14.2 (no error though). Upgrading to latest (2.16.2) fixed.
|
Curious. That usually happens when pandoc failed to retrieve the Table
object. You could try to wrap the Table in a list to get different
behavior and hopefully an error message.
We did a complete overhaul of the Lua subsystem in pandoc 2.15 and 2.16,
in part to avoid these kind of cryptic problems. Error reporting is much
better now – but still has weak points and needs a bit more work.
|
Another minor issue:
<table>
<thead>
<tr class="header">
<th>header</th>
</tr>
</thead>
<tbody>
<tr class="odd">
<td>cell 1</td>
</tr>
</tbody>
</table> With redundant header field:
<table>
<thead>
<tr class="header">
<th colspan="2">header</th>
</tr>
</thead>
<tbody>
<tr class="odd">
<td>cell 1</td>
<td>cell 2</td>
</tr>
</tbody>
</table> This problem doesn't occur when using colspan for later rows. |
@mustafa0x ah yeah, my bad ... will be fixed by #205. |
The new version introduces support for:
Furthermore the documentation has been improved.
Please don't squash my commits ;)