Bridge fixes for stable2409 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
commented
Nov 20, 2024
bkontur
commented
- Does not require a CHANGELOG entry
|
/cmd fmt |
12 tasks
|
bot fmt |
acatangiu
reviewed
Nov 20, 2024
Comment on lines
+325
to
+327
| // 1. wait for patch-release stable2409-3 2024-12-12 | ||
| // 2. go with `Ok(())` / `Err(())` | ||
| // 3. go with `XcmpQueue::send_signal` temporary workaround till patch release |
There was a problem hiding this comment.
I recommend option 1: wait for and use patch-release stable2409-3 2024-12-12
If there are other time-sensitive deliverables to be deployed with this upgrade and we can't wait for stable2409-3, then we should do 3. go with XcmpQueue::send_signal workaround.
I would not go with option 2 Ok(()) / Err(())
pandres95
merged commit ac46d87
into
pandres95:upgrade-polkadot-stable2409
45 of 47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.