fix(storage optimization): Removed and replaced used of PStore with G…

[sienna-sterling]

…etStorage

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Please make sure that your Pull Request meet the following acceptance criteria:

• Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
• The commit message uses the format of Conventional Commits
• The commit message describes what has been changed, why it has been changed and how it has been changed
• Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
• Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

• Android
• iOS
• Browser (Chromium based)
• Browser (Firefox based)
• Browser (WebKit based)
• Desktop Linux
• Desktop Windows
• Desktop macOS

[ggurdin]

@sienna-sterling Hello! This looks good. A few things:

1. When we make changes to FluffyChat file (any file that's not under the /pangea folder) we wrap those changes in comments ("// #Pangea" and "// Pangea#") to indicate that it's our code and not FluffyChat's. Can you do this for the changes in chat_list.dart? Don't worry about changes that are already inside one of these blocks.
2. All instances of GetStorage should be static

[ggurdin]

@sienna-sterling Hello! Can you also remove the changes related to link color? If you want to keep working on those, you can open a separate PR

[ggurdin]

@sienna-sterling Each PLocalKey should correspond to one GetStorageBox. For instance, PLocalKey.showedUpdateDialog is only ever used in the GetStorage box with the key "version_storage" (see app_version_util.dart). There's a few instance here where a give PLocalKey is being written to one box and read from another. These are:

1. PLocalKey.loginType is written to the box with the key "login_storage" (login.dart), but it's read from the box "settings_storage" (user_settings.dart). It's also being written to the box with the key "sso_storage" (sso_login_action.dart)
2. PLocalKey.justInputtedCode is written to the box "chat_list_storage" (chat_list.dart) and is also written to the box "class_storage" (space_controller.dart), but is only ever read from "chat_list_storage" (chat_list_handle_space_tap.dart)
3. PLocalKey.cachedClassCodeToJoin is written to the box "link_storage" (join_with_link.dart), but read and removed from the box "class_storage" (space_controller.dart)

These should all be one-to-one

[ggurdin]

@sienna-sterling Looks good! Thank you.
Can you move the GetStorage box definitions into separate files? I think we only want to define them in files in the /pangea directory, inside subdirectories where they're being used. Maybe in files ending with _constants.dart (like analytics_constants.dart)

[ggurdin]

@sienna-sterling Hello! The definitions for GetStorage boxes that were defined before this PR, like lemma_storage, don't need to be moved. Sorry if that wasn't clear.

[sienna-sterling]

@sienna-sterling Hello! The definitions for GetStorage boxes that were defined before this PR, like lemma_storage, don't need to be moved. Sorry if that wasn't clear.

@ggurdin How do I see which ones I have to put back?

[ggurdin]

@sienna-sterling I think it's any of the GetStorage box names that exist in the current main branch. I would look at the file changes in gihub

[ggurdin]

@sienna-sterling Thank you! Looks just about ready. I resolved some merge conflicts with the main branch, so make sure to pull those locally. I think the only thing left is to go through the changes files in github and remove any added spaces (in files that don't contain any storage box references) / commented out imports