Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try updating codecov #492

Merged
merged 3 commits into from
Oct 8, 2020
Merged

try updating codecov #492

merged 3 commits into from
Oct 8, 2020

Conversation

bradyrx
Copy link
Collaborator

@bradyrx bradyrx commented Oct 8, 2020

Codecov is the only thing breaking now on CI. We can't upload to it. See codecov/codecov-action#43.

@bradyrx
Copy link
Collaborator Author

bradyrx commented Oct 8, 2020

Added codecov token as a secret and directly referenced it in workflow.

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #492 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          49       49           
  Lines        4638     4638           
=======================================
  Hits         4381     4381           
  Misses        257      257           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d943e8...f87d2d7. Read the comment docs.

@bradyrx
Copy link
Collaborator Author

bradyrx commented Oct 8, 2020

Posts the coverage to the PR but calims to fail upload. Will set CI fail to false on upload fail and see if codecov updates.

@bradyrx bradyrx merged commit 123e181 into master Oct 8, 2020
@bradyrx bradyrx deleted the update_codecov_action branch October 8, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant