-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typing annotations #692
typing annotations #692
Conversation
climpred/graphics.py
Outdated
fmt="--o", | ||
): | ||
bootstrapped: xr.Dataset, | ||
ax: Optional[plt.Axes] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if plt not installed
Codecov Report
@@ Coverage Diff @@
## main #692 +/- ##
=======================================
Coverage 93.86% 93.87%
=======================================
Files 58 58
Lines 6227 6250 +23
=======================================
+ Hits 5845 5867 +22
- Misses 382 383 +1
Continue to review full report at Codecov.
|
Description
mypy_extensions
needed? dont mypy__getattr__
Closes #685
To-Do List
Type of change
How Has This Been Tested?
mypy
Checklist (while developing)
References
https://docs.python.org/3/library/typing.html