Fix for dask 2024.12 #156
Open
Fix for dask 2024.12 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| from rechunker.types import ParallelPipelines, Pipeline, PipelineExecutor | ||
|
|
||
| # Change in how dask collection token are given to blockwise() |
There was a problem hiding this comment.
As of dask/dask#11675, there's a public dask.task_spec we can import this from. I think that was released in 2025.1.0.
Could you try adding another version check and importing it from the public location if possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #155, allowing
rechunkerto be used with dask >= 2024.12.0.The change in dask's
blockwisewas introduced in dask/dask#11568 and requires keys pointing to other dask collections to be wrapped withinTaskRefobjects. The latter were introduced in dask 2024.09, so to preserve retro-compatibility (rechunkerdoesn't pindask), I added a if-else that checks dask's version.I tested against dask 2024.9, 2024.11.2, 2024.12 and 2025.2.
Installing
apache-beamrequiresdask < 2024.8.0because the former needscloudpickle < 2.3and the latter>=3, thus I didn't test if my change had impacts on theapache-beamtests. (I guess it shouldn't...)