Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove black formatting in notebooks #50

Closed
wants to merge 1 commit into from

Conversation

raphaeldussin
Copy link
Contributor

fails in PR #24 for no obvious reason

@andersy005 do you want to chime in?

fails in PR #24 for no obvious reason
@aulemahal
Copy link
Collaborator

aulemahal commented Nov 25, 2020

I found the error!
The prenotebook hook uses prettier to prettify the notebook markdown cells (and code cells if --prettier-code is given). prettier is written in javascript and a legacy version is shipped with prenotebook. However, to run, it needs nodejs, which I did not have on my machine, but is somehow accessible in github's actions.

A fix for this would be to add nodejs in ci/environment.yml.

@raphaeldussin raphaeldussin deleted the raphaeldussin-precommitdirtyfix branch November 25, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants