-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pyproject.toml for setuptools >= 69.0.0 #153
Conversation
for more information, see https://pre-commit.ci
…ngeo-forge-runner into gcorradini/historyserver
for more information, see https://pre-commit.ci
…ngeo-forge-runner into gcorradini/historyserver
086fc8d
to
b1505a3
Compare
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 15 15
Lines 495 495
=======================================
Hits 477 477
Misses 18 18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranchodeluxe apologies for the delay here somehow I missed the initial ping.
I am not able to reproduce the error you describe in #152, and therefore pending further discussion am not convinced this PR is needed.
I just:
- Created an empty python 3.10 venv
- Upgraded setuptools to
69.0.2
- Checked out pangeo-forge-runner
main
- Ran
pip install -e .
without error
Beyond this experiment, I am a bit confused why the release note you quoted in #152
Added strict enforcement for project.dynamic in pyproject.toml. This removes the transitional ability of users configuring certain parameters via setup.py without making the necessary changes to pyproject.toml (as mandated by PEP 612). (pypa/setuptools#4066)
...would affect us here, given that we don't have a setup.py?
Totally open to the possibility that I'm missing something here.
Yeah, not sure. I might be missing something too b/c it works for me now as well but was definitely blocking me until I had this fix in. I think closing it is fine. Somehow I got here through the maze of links that started here maybe: https://stackoverflow.com/questions/77523055/missingdynamic-license-defined-outside-of-pyproject-toml-is-ignored |
Python's packaging disaster makes me want to switch languages
Addresses: #152