Add flink parallelism args #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
===========================================
+ Coverage 86.30% 96.85% +10.55%
===========================================
Files 13 13
Lines 409 414 +5
===========================================
+ Hits 353 401 +48
+ Misses 56 13 -43
|
yuvipanda
requested changes
Aug 3, 2023
yuvipanda
reviewed
Aug 4, 2023
|
@yuvipanda's review items are addressed and I've just added a test for them (which gave us an outsize boost on coverage, because it's actually the first FlinkOperatorBakery unit test 🎉 ). The only test failure is the known-to-be-broken Flink integration test. Going to merge this now so @rsignell-usgs can keep going on his awesome Pangeo Forge experiments (e.g. hytest-org/hytest#350). Happy to address any loose ends in follow-on PRs. 🙏 |
yuvipanda
added a commit
that referenced
this pull request
Aug 19, 2023
This is the behavior of newer apache beam versions, let's match that. It reverts my suggestion from #82 (comment)
1 task
yuvipanda
added a commit
that referenced
this pull request
Aug 19, 2023
This is the behavior of newer apache beam versions, let's match that. It reverts my suggestion from #82 (comment)
yuvipanda
added a commit
that referenced
this pull request
Aug 20, 2023
This is the behavior of newer apache beam versions, let's match that. It reverts my suggestion from #82 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds args discussed in #19 (comment) to the Flink bakery.
cc @rsignell-usgs