Quoted string as object key not supported

[alexlafroscia]

Since pulling the updates from today, my highlighting has been way off.

None of the consts are highlighted anymore, as are... Well, most other things. It was all fine before develop was merged in today.

---

Edit: It's been determined that the issue is specifically with the following kind of syntax

const obj = {
  'my-method'() {
    return ...;
  }
};

[amadeus]

This is probably the result of your color scheme. We've added a lot more syntax granularity, but it's possible your color scheme isn't matching up to these links well.

Can you link me to your color scheme file and I can look into perhaps better link things up?

[alexlafroscia]

Hmm, interesting. I'm using gruvbox.

[alexlafroscia]

Huh, it looks like it might just be that one file, not a universal problem. Here's a different file, same Vim config

Things look pretty normal there, so maybe it's just a problem with the first file I showed. Could it be that the red mark on that line that starts with add-to-cart is throwing everything after it off?

[amadeus]

Ahah, I think I can see the issue in your first file. It's a type of ES6/7 syntax I never thought to support.

var obj = {
    'key-name'() {}
};

For now, if you changed it to:

var obj = {
    ['some-key']() {}
}

Then it should fix itself. I will work on supporting that string key into parentheses syntax shortly though.

[alexlafroscia]

Alright, cool. It's not something I can change in my codebase, but I'm glad to know it'll be handled sometime soon.

[amadeus]

I have a fix for this that is going into develop shortly. Thanks for the heads up!

[alexlafroscia]

Awesome! Thanks for the quick turn-around there, I'll install from develop and check it out.

Edit: Just installed it, that fixed my problems!

[amadeus]

Awesome, closing this, as this fix will be going out shortly.

[alexlafroscia]

Thanks again for the quick turn-around!

[amadeus]

This is fixed in develop, gonna close this as it should be going into master soon.