Support multi-GPU training for supervised training #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksikka
force-pushed
the
feature/multi-gpu-sup
branch
5 times, most recently
from
c957083
to
b81f011
Compare
themattinthehatt
requested changes
Oct 17, 2024
tests/utils/test_scripts.py
Outdated
| # assert num_gpus gets modified to 1 | ||
| assert cfg.training.num_gpus == 1 | ||
| # the rest of the behavior follows correctly | ||
| assert data_module.train_batch_size == 4 |
There was a problem hiding this comment.
compare to value in cfg rather than hard code (same for two below)
ksikka
force-pushed
the
feature/multi-gpu-sup
branch
from
ac6cdf3
to
3d66e39
Compare
ksikka
force-pushed
the
feature/multi-gpu-sup
branch
from
3d66e39
to
1317e92
Compare
ksikka
commented
Oct 17, 2024
ksikka
commented
Oct 17, 2024
ksikka
commented
Oct 17, 2024
themattinthehatt
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.