Do not hold cs_vNodes in CSigSharesManager::SendMessages() for too lo…

…ng (PIVX-Project#2758)
panleone · Oct 30, 2024 · 9b56ef5 · 9b56ef5
1 parent a29d294
commit 9b56ef5
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/llmq/quorums_signing_shares.cpp b/src/llmq/quorums_signing_shares.cpp
@@ -1048,7 +1048,9 @@ bool CSigSharesManager::SendMessages()
 
     bool didSend = false;
 
-    g_connman->ForEachNode([&](CNode* pnode) {
+    std::vector<CNode*> vNodesCopy = g_connman->CopyNodeVector(CConnman::FullyConnectedOnly);
+
+    for (auto& pnode : vNodesCopy) {
         CNetMsgMaker msgMaker(pnode->GetSendVersion());
 
         auto it1 = sigSessionAnnouncements.find(pnode->GetId());
@@ -1133,9 +1135,10 @@ bool CSigSharesManager::SendMessages()
                 didSend = true;
             }
         }
+    }
 
-        return true;
-    });
+    // looped through all nodes, release them
+    g_connman->ReleaseNodeVector(vNodesCopy);
 
     return didSend;
 }