-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix #50
- Loading branch information
Showing
2 changed files
with
9 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0908260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new dependencies are not compatible with python 3.5.
I confirm it work with python 3.9.
0908260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh? I tested it with Python 3.5 and the Docker image uses 3.5.
Which dependencies?
0908260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For python 3.5, you need :
requests==2.24
libsass==0.19.4
pyGitHub==1.54
instead of :
requests==2.25.1
libsass==0.20.1
pyGitHub==1.54.1
0908260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the only thing is pyGitHub, this one I actually missed. Will fix that.
The rest are officially available for 3.5.
0908260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this!
0908260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for libsass, the github page doesn't list python 3.5 as compatible : https://github.com/sass/libsass-python for 0.20.1
and when you check the package in https://pypi.org/project/libsass/0.19.4/ , 0.19.4 is the last one to list 3.5
0908260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.20.1 still lists 3.5 as compatible:
They just don't release binaries anymore.
I think I'll move Kitana towards 3.7 now. 3.5 is basically EOL.