Skip to content

Commit

Permalink
bump 0.3.3
Browse files Browse the repository at this point in the history
fix #50
  • Loading branch information
pannal committed Jan 17, 2021
1 parent feb1fc9 commit 0908260
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
0.3.3
- update dependencies
- use python 3.5 explicitly
- support -A allowing a global Plex token to be supplied via command line or environment variable name, fully supporting "no-login"-mode without the need to authenticate.
- possibly fix #50

0.3.2
- update dependencies
- support relay connections
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ optional arguments:
-P [BOOL], --behind-proxy [BOOL]
Assume being ran behind a reverse proxy (default:
False)
-A GLOBAL_AUTH_TOKEN, --global-token GLOBAL_AUTH_TOKEN
Token to access Plex. Can be the name of an
environment variable.
-PH [PROXY_HOST_VAR], --proxy-host-var [PROXY_HOST_VAR]
When behind reverse proxy, get host from this var
(NGINX: "Host", Squid: "Origin", Lighty/Apache:
Expand Down

7 comments on commit 0908260

@Denbrea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new dependencies are not compatible with python 3.5.
I confirm it work with python 3.9.

@pannal
Copy link
Owner Author

@pannal pannal commented on 0908260 Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? I tested it with Python 3.5 and the Docker image uses 3.5.

Which dependencies?

@Denbrea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For python 3.5, you need :
requests==2.24
libsass==0.19.4
pyGitHub==1.54

instead of :
requests==2.25.1
libsass==0.20.1
pyGitHub==1.54.1

@pannal
Copy link
Owner Author

@pannal pannal commented on 0908260 Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip -V
pip 9.0.1 from /home/panni/.pyenv/versions/3.5.9/envs/35test/lib/python3.5/site-packages (python 3.5)

pip freeze
certifi==2020.12.5
chardet==4.0.0
Deprecated==1.2.11
idna==2.10
libsass==0.20.1
PyGithub==1.54
PyJWT==1.7.1
requests==2.25.1
six==1.15.0
urllib3==1.26.2
wrapt==1.12.1

So the only thing is pyGitHub, this one I actually missed. Will fix that.

The rest are officially available for 3.5.

@pannal
Copy link
Owner Author

@pannal pannal commented on 0908260 Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this!

@Denbrea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for libsass, the github page doesn't list python 3.5 as compatible : https://github.com/sass/libsass-python for 0.20.1
and when you check the package in https://pypi.org/project/libsass/0.19.4/ , 0.19.4 is the last one to list 3.5

@pannal
Copy link
Owner Author

@pannal pannal commented on 0908260 Jan 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.20.1 still lists 3.5 as compatible:
image

They just don't release binaries anymore.

I think I'll move Kitana towards 3.7 now. 3.5 is basically EOL.

Please sign in to comment.