Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Movie Score 110, but subtitles are +7 sec. ahead of the action. #676

Closed
cphmichael opened this issue Sep 19, 2019 · 28 comments
Closed

Movie Score 110, but subtitles are +7 sec. ahead of the action. #676

cphmichael opened this issue Sep 19, 2019 · 28 comments

Comments

@cphmichael
Copy link

This morning at 07:24, Radarr upgraded Spider-Man from Bluray to Remux, and SZ upgraded the subtitles.

When I played the movie, the subtitles was +7 sec. ahead of the action.

In Kitana I can see that SZ has scored the subtitles to 110. That is a quite high score for a movie, which normally gives a correct subtitle.

If you look at the attached Kitana screen dump, you can see that the subtitles with score 110 has “wrong FPS, sub: 60.000, media: 23.976”

If you look at the other attached Kitana screen dump, you can see that I did a manual install of the subtitles that scored 102. This subtitles played perfect without any offset problems.

The subtitles with score 102 has no error and match perfect with the movie.

My thought is therefore, if it is fair that SZ gives the subtitles with wrong FPS such a high score.

Could there be an error in the SZ code that scores wrong?

com.plexapp.agents.subzero.log
com.plexapp.agents.subzero.1.log

Radarr - Spider-Man upgrade

Kitana

Kitana 2

@viking1304
Copy link

If you want to be sure that you will get perfect match, you absolutely need to have format matched too. This is not the case here. WEBRip is not same as BluRay. One version probably have one additional 7 seconds block in the beginning.

I would not recommend setting score too high, since you might miss perfectly good subs, such as that one with score of 102 (witch actually match format).

Based on your screenshot, those were matches: hearing_impaired 1 + year 30 + video_codec 2 + title 60 + resolution 2 + release_group 15 or 110 in total.

In most cases, matching release group would more likely give you right subs than matching the format, since it is possible that someone mark format differently than someone else (for example webrip and webdl).

Your filename "Spider-Man Far from Home (2019) Remux-1080p.mkv" doesn't have release group in it, so i am not sure why release group it is matched. Might be a bug in opensubs provider. Everything else is perfectly correct.

Since @pannal is on vacation, I will try to check your logs and test this later myself if I find some time.

@cphmichael
Copy link
Author

Hi @viking1304

Thank you for your reply :-)

I have looked everywhere for 'format match' but can not find this settings.

Is it called something else in the SZ settings?

I have Minimum score for moves set to 98

Regards
Michael

@viking1304
Copy link

Let's try to be as clear as possible to avoid any further confusion.

A format is the source of your video (movie or series episode), that can be one of those: HDTV, BluRay, WEB-DL, WEBRip, DVDRip, ...

A score that you are setting in SZ is called media score. Every element of your filename has a specific value in the final calculation.

Your score set to 98 is perfectly fine. That is a minimal score. The minimal requirement to get a match if you use that value is that your file and subtitle have those same values:

the same title, the same year, same format, and the hearing impaired flag
(title 60 + year 30 + format 7 + hearing_impaired 1)

the same title, the same year, same video codec, same audio codec, same resolution, and the hearing impaired flag
(title 60 + year 30 + video_codec 2 + audio_codec 3 + resolution 2 + hearing_impaired 1)

In most cases, a higher score means that you will get subtitle that better match your video, but it is still possible that better subtitle has a lower score. It depends on your file name and what is set as release info for specific subtitle. Subzero will try to get as much info from your file name as possible, but you can still help a lot with better file names.

I am not sure what was the problem in this specific case, but I will try to investigate if I find the time.

@cphmichael
Copy link
Author

Thank you for your explanation :-)

So when you wrote "You absolutely need to have format matched too. This is not the case here" It is not an option that I have forgot to enable in the SZ settings?

@viking1304
Copy link

Sorry for confusion, I simply wanted to say that source of your file was BluRay and that you need BluRay sub if you want perfect match. You can't be sure that WEB-DL or WEBRip are perfect match for your video. I hope everything is finally clear. :)

@cphmichael
Copy link
Author

Thank you for your clarification :-)

@pannal
Copy link
Owner

pannal commented Sep 19, 2019

Yeah, basically: The match on opensubs is wrong due to it only matching the REMUX part, which may be whatever (BluRay REMUX, HDTV etc).

What I'm curious about is, though, why SZ picked that subtitle even though its clearly the wrong framerate.

The info must have changed after the subtitle was downloaded. Now it seems like the info on the subtitle was updated to include FPS as well and SZ wouldn't have picked that subtitle if the info had been present before.

In that case you can re-download the current one or blacklist the current one to get a new one.

Nothing much we can do about that.

Edit: Clarification
Edit 2: See below

@pannal
Copy link
Owner

pannal commented Sep 19, 2019

Wait, there's something fishy going on.

Do you use advanced_settings.json and have skip_wrong_fps as False? SZ actually doesn't skip wrong FPS in OpenSubtitles for you. This might be a bug or a misconfiguration.

@pannal
Copy link
Owner

pannal commented Sep 19, 2019

Your SZ instance definitely goes into the else-block here:

- which should only happen if you actually disable FPS verification in advanced settings.

@viking1304
Copy link

@pannal - if i am reading correctly, filename is Spider-Man Far from Home (2019) Remux-1080p.mkv and subtitle release is 1080p.WEBRip.x264-[YTS.LT]

So how release group was matched? Looks like I bug, bud I didn't have time to look at logs or to test this.

@pannal
Copy link
Owner

pannal commented Sep 19, 2019

@viking1304 nah, all good. He uses Radarr as refiner; to reduce the load on the refiners SZ doesn't show the "real" filename in the menus. The filename that was searched for was Spider-Man Far from Home.2019.1080p.BluRay.REMUX.AVC.DTS-HD.MA.7.1-EVO.mkv.

It probably matched via tags on OS, matching the release group of a "similar release", which doesn't show in the menu, either (and we don't get that info from the API).

The issue here is that SZ doesn't skip the bad FPS. It detects it properly, but takes the wrong path.

@cphmichael
Copy link
Author

I do not use the advanced_settings.json

Is your conclusion that this is a bug or do you need more logs or testing from me?

@pannal
Copy link
Owner

pannal commented Sep 20, 2019

Can I have a log after an SZ restart? Ideally all your SZ logs zipped.

@cphmichael
Copy link
Author

I did a PMS docker restart - I hope that is the same as a SZ restart.

I have attached all my SZ logs after the docker restart:

SZ.zip

pannal added a commit that referenced this issue Sep 20, 2019
@pannal
Copy link
Owner

pannal commented Sep 20, 2019

You've actually hit a long standing bug. Neither default advanced settings where used when no advanced_settings.json was present. Disabling OpenSubtitles skip wrong FPS in the process (as well as another setting for OS).

Please try latest develop.

@pannal
Copy link
Owner

pannal commented Sep 20, 2019

Thanks for bringing this to my attention. This will seriously improve the likeliness of false-positives for anyone not using advanced_settings.json on OpenSubtitles.

@pannal
Copy link
Owner

pannal commented Sep 20, 2019

You can actually test this fix by force-refreshing the item in question.

@cphmichael
Copy link
Author

cphmichael commented Sep 21, 2019

(with old SZ dev version)
This morning at 8:30 Radarr upgraded Spider-Man from Remux-1080p to Remux-2160p and downloaded a subtitle from Opensubtitles with a score of 98.
I played the movie for a few minutes and the downloaded subtitles is perfect.

At about 14:00 I upgraded to Sub-Zero 2.6.5.3144 DEV.

I think there is a problem with 2.6.5.3144 DEV, because in Kitana I clicked on Spider-Man > Manage English Subtitle > List available English Subtitles > Search for English Subs

Normally, after 30 sec. I can click on the 'refresh here' and I get a list of available subtitles, but now I do not get any subtitles.

I did as you last requested - Restart the PMS docker, and ZIP all the Sub-Zero log-files.

SZ.zip

@pannal
Copy link
Owner

pannal commented Sep 21, 2019

Damn. Holiday-mind is not up to snuff :D
Pushing fix.

Edit: 3146 pushed

@cphmichael
Copy link
Author

I have installed 3146 and now I get a subtitles list.

Spider-Man was upgraded, so I can not test if the match problem is fixed, but let hope so :-)

@pannal
Copy link
Owner

pannal commented Sep 21, 2019

Well you can - force-refresh it from the menu (Kitana). The issue was not the upgrade, but that SZ decided to use the subtitle with a bad framerate.

@cphmichael
Copy link
Author

I think there is another problem I would like to open a ticket for, but I am not sure if it is a SZ or Kitana issue.

I therefore quickly ask you here - Hope that is ok :-)

I have discovered that for some old TV Series, that have an external .srt subtitles file, Kitana says "No current subtitles in storage".

For newer TV Series there is no problem.

@pannal
Copy link
Owner

pannal commented Sep 21, 2019

Yeah those are either external subtitles which were not provided by SZ, or the storage was corrupted for those older items. Nothing much that I can do there :/

@pannal
Copy link
Owner

pannal commented Sep 21, 2019

When SZ talks about its "storage", it usually means the subtitle metadata storage that SZ manages itself, which holds score information, the actual content of the subtitle, source/provider etc. That is mainly used for subtitle modifications or upgrades.

If it doesn't "know" about a subtitle (e.g. it doesn't have data stored for it from a previous download), it will say so.

Edit: Not to be confused with the Plex Metadata storage, which can also hold subtitles (but no further information)

@cphmichael
Copy link
Author

Okay, fine - No problem, for the Subtitles are there and SZ can download a new one without any problems.

@pannal
Copy link
Owner

pannal commented Sep 21, 2019

It should also be able to download new ones for the ones without any subtitle in storage. It just wouldn't be able to find better ones than the existing ones, because it doesn't know how good the existing ones are.

@cphmichael
Copy link
Author

A "force-find subtitles" in Kitana seems to work without any problems.

Thank you very much for taking time to look into it on you vacation :-)

Screenshot from 2019-09-21 17-34-34

@pannal
Copy link
Owner

pannal commented Sep 21, 2019

My pleasure :)

@pannal pannal closed this as completed in f4e82c5 Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants