Automatic extraction of subtitles not working #711
Comments
|
Here are the PMS Plugin Logs if you need them: https://www.dropbox.com/s/rd8cela7dii9160/PMS%20Plugin%20Logs.zip?dl=0 |
|
One example media filename that doesn't have an SRT: Arrow (2012) - S08E01 - Starling City - [WEBDL-1080p] [EAC3 5.1ch] [h264 8bit] - Sonarr.mkv Even though the release group was not parsed correctly by Sonarr, I have the Sonarr API in the SZ settings so SZ should be able to query for the original filename in Sonarr. In the logs I posted above, I had the "Don't search for subtitles of a language if there are embedded subtitles inside the media file (MKV/MP4)?" setting checked so I thought that was the one causing it. I unchecked that and refreshed the metadata again but the result is still the same. |
|
|
You seem to be using mediainfo, which results in an error with a couple of mp4 files in your logs. Can you post the output of Thanks! |
|
And do the same for |
Oh ok. So no way of extracting PGS subtitles and saved to SRT then? Here's the mediainfo output: |
|
I'm doing all these because the Plex seems to be transcoding the video when the subtitles are PGS. |
|
Please also do Edit: I can't see any PGS subtitle inside the Starling City one. Is that not the one you're referring to? |
It has to. It can only direct play videos with text based subtitles. Otherwise it has to overlay the bitmap based subtitle over the video stream, which can only be done by transcoding. |
|
Was |
|
I get this for S08E01: -3_SDH Oops, you can disregard S08E01 if it doesn't have a PGS sub. Sorry about that. This is the one I'm sure about that has a PGS: Arrow (2012) - S06E16 - The Thanatos Guild - [Bluray-1080p Remux] [DTS-HD MA 5.1ch] [AVC 8bit] - EPSiLON.mkv And yes, almost all of these were recently updated by Sonarr. So if an update happens, how can SZ update the sub as well? |
Yes SZ will upgrade the subtitles accordingly and remove the previous one |
That's what I thought. Also manually refreshing the metadata will always trigger the agents (including SZ), correct? I did refresh all metadata so it should've extracted the subs. Also, the reason why I brought up S08E01 as one episode that has an issue is because Plex detects the episode with an SRT sub (and plays it successfully with a sub) even though I don't exactly see an SRT in the same folder as the media file. I tried playing it just now and it did play with a sub and then after a few seconds, a sub was downloaded correctly. I'm assuming this is because of the "hybrid-plus" setting I have set. But still, why would Plex show that it has an SRT sub if it doesn't have the actual physical file? And would it really play with a sub right away even if it still in the process of downloading it when you play a file? I was assuming that it kinda take a minute to download and display the sub with the hybrid-plus setting. Or are there embedded SRT subs? Here's a concrete example of what I'm saying:
Look how S08E06 doesn't have an SRT file in that same folder but Plex recognizes that it does. And when I play this file, it "right away" displays the subs. And then after a few seconds the subs for S08E06 and S08E07 get downloaded. This behavior DOES NOT happen for Also, the upgrades that happened for these Arrow episodes did change the filenames, that's for sure. And like I said above, regardless if the filenames were changed or not, I was assuming that the "refresh all metadata" option in Plex, will retrigger SZ to do its thing. Or am I assuming incorrectly? |
|
You're mistaking what Plex UI tells you. This is the difference between Non-External are embedded. |
|
Please try the latest develop-2.6 branch; I've tried fixing your mp4 stream detection issue. Automatic extraction for S08E03 might now work. |
Aha! I knew there was something off with how I understood English (SRT). Thanks for the clarification!
Ok, great. I'll try this out. However, some questions:
|
|
Btw, are these the correct instructions for updating to the develop branch? Is there a way to have it configured so that SZ is automatically updated when a new version of the develop branch comes out? If you remember, I'm using LSIO's plex docker container. Would a startup script for the container similar to this work? apt update ? |
Yes.
It shouldn't, SZ can't do anything with PGS, as it's image based.
Exactly. I want to have a subtitle right away. Also this way it doesn't need to trigger the providers on every new addition.
That depends. For WEB-DLs it doesn't really matter as most of the ones available are at least derived from if not complete copies of the embedded ones. It's more interesting for BluRay and DVD, as the subtitles shipped might not have been correctly OCR'd and often contain errors - SZ will fix most of them, but community-created subtitles are almost always better in this case.
Yes.
Yep.
Yes, but it might be easier/faster to always just fetch the latest zip of that branch: https://github.com/pannal/Sub-Zero.bundle/archive/develop-2.6.zip |
But should it still download a new subtitle from the providers for the episode that has only PGS subs in it?
What do you mean this way it doesn't need to trigger the providers on every new addition? Are you pertaining to when the "After...." setting is checked or unchecked?
So if this setting is checked and the "After..." setting is checked, which has a higher priority when the media file has an embedded sub? Because what will happen is that SZ extracts the embedded subs which, according to you, will be considered as a "pre-existing" sub file. After extraction, will SZ still download a sub for that media file?
Ok, got it. Is there a way to have the develop branch always automatically be updated just like the stable branch? Also, if I remove the SZ folder under Plug-ins, will my settings be retained after git cloning the dev repo? |
|
One more example for media files with embedded PGS subs. If I have the For the subtitle update schedule, will SZ treat all media as fair game? My head is exploding as to which setting takes precedence over which setting :( A flowchart would be very very nice to explain all these, just a thought. |
|
Any updates @pannal ? |
Yes, as long as you don't have
When that option is checked, an additional search is explicitly done upon addition of a new media file, when an embedded subtitle has been extracted. Leaving this disabled lessens the impact on the providers obviously, as the next check would be a scheduled one.
The pre-existing check is done before the embedded detection/extraction is done. If you have the "After..." checked, it will still search the providers. The order is:
No, that's impossible due to the way the Plex plugin updater handles things.
Pretty much always. The only way to effectively kill your settings is to actually delete the Plugin XML or move so weirdly between versions that some migration process breaks things. Never happened before.
Only if you have |
I don't have that setting enabled but when I search subs for that episode, I still don't get any. That specific episode (the one with PGS) was recently upgraded by Sonarr so SZ should know the original filename by querying Sonarr. One concrete example is: I've refreshed the metadata for the Arrow series several times now but I still don't get any subs for that episode which has embedded PGS subs. Here are the latest set of logs with dev 2.6: https://www.dropbox.com/s/rd8cela7dii9160/PMS%20Plugin%20Logs.zip?dl=0
So then the extracted sub will not really be considered "pre-existing" during the first ever processing for a specific episode, correct? Because SZ checks the current state of affairs before extracting the embedded subs, it sees no pre-existing file, does it? And if there is already a pre-existing SRT for a media file, will SZ still try to extract the embedded sub? I'm assuming not anymore. Also, what is your take on my reply here? |
The log is incomplete, it cuts off at the end where it gets interesting regarding S06E16. Can you reupload?
Yes.
As long as you don't have |
|
Ok, that's weird. I checked again and now all my episodes in Arrow have subtitles already! So I guess the refresh all metadata didn't get everything but the scheduled task did? What could be the cause of that? Here's a re-upload of the logs: https://www.dropbox.com/s/rd8cela7dii9160/PMS%20Plugin%20Logs.zip?dl=0 |
|
Also, what caused the stable release not successfully get most subs? Is it because I'm using mediainfo and your code for the stable released lacked support for that or something? |
The Arrow run seems to have taken over most of the logs, so I can't really see what was going on with S06E16.
The develop-2.6 branch has the fixes for the issues I've been able to find in your original logs. |
|
If I delete the subs for S06E16 and retrigger a refresh metadaya for arrow again, would that accurately recreate the same scenario? |
|
There are a couple of instances where this could happen. For example if one of the providers isn't reachable or throttled at that specific moment. You should be able to retrigger using the method you described, yes. |
|
Is it generally safe to stay with the develop branch? If I understand correctly, the dev branch will always be ahead of the stable branch, correct? |
|
Yeah, it's usually safe. You're missing out on automatic updates, that you only get with stable releases, though. |
|
Oh ok, I forgot about that. For this specific issue though, will the fix be in the stable release anytime soon? |
|
I'm preparing for a new stable release next weekend. |
|
Now how do I revert back to the stable release without destroying anything? |
@pannal I'm still confused with this statement. Let' say a new file has an embedded subtitle and I have these settings:
So when the media gets added, SZ will:
So with these events, the Also, are all the settings on those pic only applicable for new additions? For example, since during the next scheduled run SZ already sees a "pre-existing" srt file for that sample above, will it still update the sub if a better one is found? |
|
Also, I'm looking at my subzero plugin logs and all I can see are queries to subscene. I have addic7ed and anti-captcha enabled but I don't see any attempts to query addic7ed. I'm using the latest stable version (switch back from the develop-2.6 branch). |
|
@pannal Any updates on this? Do you need me to create a new issue? |
|
nice head exploding topic:) but it won't download another copy to internal storage., luckily. but i'm worried about endless processing of same media. i was hoping to have SZ download subtitles in its own storage no matter if external subtitles exist. and by external i mean files. (i've checked XML generates names for each subtitle, but it's not present in Plex files..so it must be generated realtime.. tried to trick SZ to use distinguishable rare VTT format to save but it doesn't work on internally saved files)
i think i'd need metadata only checkbox:
and ideally called "SRT Internal" but i guess Plex won't allow it. so have to stick to this confusing duplicit naming. |
I have automatic extraction of embedded subtitles enabled. I refreshed all metadata of my tv show library. So I'm expecting everything with an embedded subtitle to at least have an accompanying srt file if SZ cannot search for a better one from the subtitle providers, right? One of the first shows that was refreshed was Arrow but looking at the media files with embedded PGS subtitles, I still don't see any SRT files for them.
Also, when embedded subtitles extraction happens, it creates an SRT file and removes the embedded subs from the media files themselves, right?
What logs do you need to look at?
The text was updated successfully, but these errors were encountered: