Support allocated instances #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobEvelyn
commented
Jan 4, 2021
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 602 623 +21
=========================================
+ Hits 602 623 +21
Continue to review full report at Codecov.
|
JacobEvelyn
commented
Jan 4, 2021
JacobEvelyn
force-pushed
the
support-allocate
branch
from
c367add to
adc070a
Compare
ms-ati
reviewed
Jan 4, 2021
|
Some questions up, but overall awesome find on |
ms-ati
requested changes
Jan 4, 2021
JacobEvelyn
force-pushed
the
support-allocate
branch
2 times, most recently
from
4d9857c to
42c435c
Compare
JacobEvelyn
commented
Jan 5, 2021
| |`(a, *args)`|**baseline**|2.02x slower|2.28x slower|1.99x slower|1.99x slower| | ||
| |`(a:, **kwargs)`|**baseline**|1.93x slower|2.07x slower|1.87x slower|1.92x slower| | ||
| |`(a, *args, b:, **kwargs)`|**baseline**|1.94x slower|2.15x slower|1.92x slower|1.93x slower| | ||
| |`()` (none)|**baseline**|12.27x slower|2.57x slower|1.22x slower|3.22x slower| |
There was a problem hiding this comment.
JacobEvelyn
force-pushed
the
support-allocate
branch
from
42c435c to
0f186fe
Compare
ms-ati
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging:
README.mdand update this PRCHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning