-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
86 GITHUB_EMBED #9295
86 GITHUB_EMBED #9295
Conversation
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9295-documentation.appa.pantheon.site |
@@ -23,7 +23,72 @@ Pantheon backups are stored offsite on Google Cloud Storage instances. We recomm | |||
|
|||
<Download file="pantheon-backup-to-s3.sh" /> | |||
|
|||
GITHUB-EMBED https://github.com/pantheon-systems/documentation/blob/main/source/scripts/pantheon-backup-to-s3.sh.txt bash GITHUB-EMBED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rachelwhitton should we delete these .txt
files too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because the download component expects it to be there for the button to work above the code snippet (used in cases where we are giving a full bash script for the user to run)
|
||
<Accordion title={"Full text of wp-config-local-sample.php"} id={"full-wp-config-local-sample"}> | ||
|
||
GITHUB-EMBED https://github.com/pantheon-systems/WordPress/blob/default/wp-config-local-sample.php php GITHUB-EMBED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rachelwhitton we should probably retain the link to this file, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's linked above on line 215
@@ -47,19 +47,153 @@ Read the comments in the scripts carefully to ensure that you modify variables c | |||
|
|||
<Download file="collect-logs-rsync.sh" /> | |||
|
|||
GITHUB-EMBED https://github.com/pantheon-systems/documentation/blob/main/source/scripts/collect-logs-rsync.sh.txt shell:title=collect-logs-rsync.sh GITHUB-EMBED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another .txt file to possibly delete
@@ -71,7 +205,7 @@ You can run the script with parameters for reusability. | |||
|
|||
1. Edit the 'collect-logs-rsync.sh' (you can choose to disable the AGGREGATE_NGINX): | |||
|
|||
```bash{promptUser:user} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an unrelated fix? I'm fine with including it if it's generally beneficial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated, just noticed it was used incorrectly as i was fixing other things on the page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rachelwhitton I should review the build when it completes too but I've already added some questions/comments.
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9295-documentation.appa.pantheon.site |
Summary
Removes
gatsby-remark-github
npm package, removes related config fromgatsby-config.js
, removes setup instructions from theREADME.md
file, and replaces instances of usage across the docs with either a crosslink or a manual copy of the code snippets instead of using GITHUB_EMBED: