[SITE-372] allow subdirectory networks warning to be filtered #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the message applies the filter so the individual calls don't need to do a check
it's not actually standard in the source because WP is dumb and no one looks at this page.
pwtyler
approved these changes
Jul 19, 2024
Co-authored-by: Phil Tyler <phil.tyler@pantheon.io>
jazzsequence
deleted the
site-372-allow-subdirectory-networks-warning-to-be-filtered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function that just returns a warning that appears on the Network Setup page in subdirectory multisite installs when the wp-content directory is modified (e.g. as it is in Bedrock). It then implements a filter to disable the warning that WordPress (Composer Managed) can consume (see pantheon-systems/wordpress-composer-managed#144).
A test has been added to validate the output of the new function both before and after the filter has been applied.