Move SitesCache invocation out of Site model

[bensheldon]

Make responsibilities a little clearer and the Site model a little more free-standing by removing any reliance on caching.

Question: what's the best way to shadow static methods with instance methods? Apparently PHP won't let them have the same name.

[TeslaDethray]

Should this function be private?

[bensheldon]

Yeah... I wasn't really sure. The instance is mostly there for OOPness, but I don't really expect the instance to be really used. I'll just make it private.

[bensheldon]

@TeslaDethray I just made the method private. Can you please take another look at this PR? Thanks!

[TeslaDethray]

+1
To answer your question, since PHP doesn't support overloading as other languages do, the way you would make it work as though it did would to access both functions via __call($function, $args) and __callStatic($function, $args) and have it map the call to the true names of these functions. I would use:

public function findInstance($args) {
...
}
public function __call($function, $args) {
  $function_name = $function . 'Instance';
  return $this->$function_name($args);
}
public static function __callStatic($function, $args) {
  $function_name = $function . 'Instance';
  $this_class = new ThisClass();
  return $this_class->$function_name($args);
}

That being said, it's neither elegant nor great for readability. PHP overloading is a strange game, and the only winning move is not to play.