Merge pull request #99 from pantheon-systems/patch-1

`destroy()` should return with a value
pantheon-systems · May 15, 2018 · 0ab0a23 · 0ab0a23
2 parents 732b5ba + 96e19fe
commit 0ab0a23
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -3,7 +3,7 @@
 **Tags:** comments, sessions  
 **Requires at least:** 3.0.1  
 **Tested up to:** 4.9  
-**Stable tag:** 0.6.8  
+**Stable tag:** 0.6.9  
 **License:** GPLv2 or later  
 **License URI:** http://www.gnu.org/licenses/gpl-2.0.html  
 
@@ -66,6 +66,9 @@ However, if you intend to scale your application, local tempfiles are a dangerou
 
 ## Changelog ##
 
+### 0.6.9 (May 15th, 2018) ###
+* Ensures `_pantheon_session_destroy()` uses a return value.
+
 ### 0.6.8 (May 4th, 2018) ###
 * Switches to `E_USER_WARNING` instead of `E_WARNING` when triggering errors.
 

diff --git a/callbacks.php b/callbacks.php
@@ -123,6 +123,7 @@ function _pantheon_session_destroy( $sid ) {
 
 	$session->destroy();
 
+	return true;
 }
 
 /**

diff --git a/pantheon-sessions.php b/pantheon-sessions.php
@@ -1,7 +1,7 @@
 <?php
 /**
  * Plugin Name: Native PHP Sessions for WordPress
- * Version: 0.6.8
+ * Version: 0.6.9
  * Description: Offload PHP's native sessions to your database for multi-server compatibility.
  * Author: Pantheon
  * Author URI: https://www.pantheon.io/
@@ -12,7 +12,7 @@
 
 use Pantheon_Sessions\Session;
 
-define( 'PANTHEON_SESSIONS_VERSION', '0.6.8' );
+define( 'PANTHEON_SESSIONS_VERSION', '0.6.9' );
 
 class Pantheon_Sessions {
 

diff --git a/readme.txt b/readme.txt
@@ -3,7 +3,7 @@ Contributors: getpantheon, outlandish josh, mpvanwinkle77, danielbachhuber
 Tags: comments, sessions
 Requires at least: 3.0.1
 Tested up to: 4.9
-Stable tag: 0.6.8
+Stable tag: 0.6.9
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
 
@@ -66,6 +66,9 @@ If you see an error like "Fatal error: session_start(): Failed to initialize sto
 
 == Changelog ==
 
+= 0.6.9 (May 15th, 2018) =
+* Ensures `_pantheon_session_destroy()` uses a return value.
+
 = 0.6.8 (May 4th, 2018) =
 * Switches to `E_USER_WARNING` instead of `E_WARNING` when triggering errors.
-Original file line number
+Diff line change
@@ Expand Up / @@ -123,6 +123,7 @@ function _pantheon_session_destroy( $sid ) { @@
     	$session->destroy();
+    	return true;
     }
     /**
@@ Expand Down @@