Add bypass for WP-CLI in Pantheon_Sessions->load()

[mikeschinkel]

This to eliminate Cannot change save handler when headers already sent being written to the error log.

[danielbachhuber]

Thanks @mikeschinkel ! Landing this in #151 because of build status limbo:

[danielbachhuber]

@mikeschinkel Actually, there was a reason WP Native PHP Sessions runs during WP-CLI #91

If you'd like to disable it on your own, here's documentation on how to do so: #80 (comment)

[mikeschinkel]

@danielbachhuber — I see. Thanks for the follow up.

Suggestion? Rather than enabling it to fix the problem, what about creating no-op mocks for each of the functions and have them loaded when WP-CLI is in use?

I can of course use the workaround to meet my current needs. Thanks.

[danielbachhuber]

Suggestion? Rather than enabling it to fix the problem, what about creating no-op mocks for each of the functions and have them loaded when WP-CLI is in use?

That could potentially work. Happy to look at a pull request if you'd like to put one together.

[mikeschinkel]

Happy to look at a pull request if you'd like to put one together

@danielbachhuber — Thanks for considering. I am looking into the potential of this right now.

[mikeschinkel]

@danielbachhuber — So I started down the path of trying to mock and it quickly seemed like it would be a maintenance nightmare for you.

So instead I went another direction, and this the fix to stop having it pollute the logs ends up being very simple; set session.use_cookies to '0' when WP CLI is running. Only the following change is required on line 144 of pantheon-sessions.php:

ini_set( 'session.use_cookies', defined( 'WP_CLI' ) && WP_CLI ? '0' : '1' );

If you agree I can either create a pull request, or given how simple it is maybe you can just apply it?

---

BTW, setting PANTHEON_SESSIONS_ENABLED to false does not fix this issue since the error is thrown on the call to session_set_save_handler() on line 168, and that line is not guarded by sessions being enabled.

[danielbachhuber]

So instead I went another direction, and this the fix to stop having it pollute the logs ends up being very simple; set session.use_cookies to '0' when WP CLI is running. Only the following change is required on line 144 of pantheon-sessions.php:

ini_set( 'session.use_cookies', defined( 'WP_CLI' ) && WP_CLI ? '0' : '1' );

If you agree I can either create a pull request, or given how simple it is maybe you can just apply it?

This seems like a reasonable approach to me. Landing it with #154

BTW, setting PANTHEON_SESSIONS_ENABLED to false does not fix this issue since the error is thrown on the call to session_set_save_handler() on line 168, and that line is not guarded by sessions being enabled.

Good to know!

[mikeschinkel]

Thanks @danielbachhuber!