Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document session lifetime handling #224

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Document session lifetime handling #224

merged 2 commits into from
Dec 5, 2022

Conversation

jms-pantheon
Copy link
Contributor

No description provided.

@jms-pantheon jms-pantheon requested a review from a team as a code owner November 29, 2022 18:46
CdrMarks
CdrMarks reviewed Nov 30, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
CdrMarks
CdrMarks reviewed Nov 30, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
CdrMarks
CdrMarks suggested changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@CdrMarks CdrMarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think about the suggestions I made.

CdrMarks
CdrMarks previously approved these changes Dec 1, 2022
View reviewed changes
@jspellman814
Copy link
Contributor

Please make this PR against develop as per CONTRIBUTING.md

jspellman814
jspellman814 suggested changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@jspellman814 jspellman814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text should also be added to readme.txt so it appears on WP.org.

There is automation in place to handle this (though that goes from readme.txt to README.md and you've updated the .md file), or you can copy over manually

@CdrMarks CdrMarks dismissed their stale review December 2, 2022 16:34

John's right about the readme.txt file.

@jms-pantheon jms-pantheon changed the base branch from main to develop December 5, 2022 16:22
@jms-pantheon
Copy link
Contributor Author

Thanks for that review @jspellman814 I have set this PR to be based on Develop and made the change to readme.txt

It seems like Markdown is only partially supported on WordPress.org for readme.txt files, I didn't find any examples of code blocks.

Would it be better to include this as just straight text block, or as code with each line with its single back-ticks?

https://developer.wordpress.org/plugins/wordpress-org/how-your-readme-txt-works/

@jspellman814
Copy link
Contributor

jspellman814 commented Dec 5, 2022 •
edited
Loading

@jms-pantheon We have some code samples in the solr-power readme.txt. Here's the rendering on wp.org: https://wordpress.org/plugins/solr-power/

@jms-pantheon
Copy link
Contributor Author

Wow thank you, I searched really hard for that one @jspellman814 but couldn't find an example. I've changed this to use the same 4 space indent.

jspellman814
jspellman814 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@jspellman814 jspellman814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jms-pantheon 👍

@jspellman814 jspellman814 merged commit ee53cfc into pantheon-systems:develop Dec 5, 2022
jspellman814 pushed a commit that referenced this pull request Dec 5, 2022
@jms-pantheon
Document session lifetime handling (#224)
a9949e7
jspellman814 pushed a commit that referenced this pull request Dec 6, 2022
@jms-pantheon
Release 1.3.1 (#227)
e2a753f 
* Ignore .wordpress-org directory (#223)

* Make dependabot target develop branch (#226)

* Document session lifetime handling (#224)

* Release 1.3.1

Co-authored-by: jms-pantheon <91161717+jms-pantheon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspellman814 jspellman814 jspellman814 approved these changes

@CdrMarks CdrMarks CdrMarks left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jms-pantheon @jspellman814 @CdrMarks