Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGS-6563: Add primary key if necessary #265

Merged
merged 93 commits into from
Oct 4, 2023
Merged

Conversation

rwagner00
Copy link
Contributor

@rwagner00 rwagner00 commented Sep 19, 2023

Customers who installed the plugin before version 1.2.2 have tables which are missing a Primary key. This PR adds a new WP CLI command which allows them to rectify the issue safely, and then either finalize the changes or roll them back easily.

@rwagner00 rwagner00 requested a review from a team as a code owner September 19, 2023 20:08
@rwagner00 rwagner00 changed the base branch from main to develop September 19, 2023 20:52
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • lacking tests is a concern (discussed in slack)
  • Document new behavior in READMEs
  • Update changelog(s) in READMEs
  • Add Upgrade Notice informing of the new behavior to README.txt
  • Major version bump should be included in this PR

composer.lock Outdated Show resolved Hide resolved
pantheon-sessions.php Show resolved Hide resolved
inc/class-cli-command.php Outdated Show resolved Hide resolved
@rwagner00
Copy link
Contributor Author

@pwtyler Unfortunately without the composer update, the PHP Unit tests fail on the nightly build:

https://app.circleci.com/pipelines/github/pantheon-systems/wp-native-php-sessions/1535/workflows/a9e7734b-3409-4da0-aaf1-edd5a4c90ddd/jobs/4111

Fatal error: Uncaught Error: Class "wpdb" not found in /home/circleci/pantheon-systems/wp-native-php-sessions/inc/class-session.php:269

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
bin/full-teardown-wp-tests.sh Outdated Show resolved Hide resolved
inc/class-cli-command.php Outdated Show resolved Hide resolved
readme.txt Outdated Show resolved Hide resolved
readme.txt Show resolved Hide resolved
readme.txt Show resolved Hide resolved
rwagner00 and others added 2 commits September 29, 2023 13:12
Co-authored-by: Phil Tyler <phil.tyler@pantheon.io>
.circleci/config.yml Show resolved Hide resolved
inc/class-cli-command.php Outdated Show resolved Hide resolved
pantheon-sessions.php Outdated Show resolved Hide resolved
pantheon-sessions.php Outdated Show resolved Hide resolved
pantheon-sessions.php Outdated Show resolved Hide resolved
readme.txt Show resolved Hide resolved
rwagner00 and others added 5 commits October 4, 2023 11:31
Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>
Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>
Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>
README.md Outdated Show resolved Hide resolved
tests/phpunit/test-init-plugin.php Outdated Show resolved Hide resolved
Ryan Wagner and others added 2 commits October 4, 2023 15:41
@rwagner00 rwagner00 merged commit 60030f5 into develop Oct 4, 2023
5 checks passed
@rwagner00 rwagner00 deleted the BUGS-6563-Primary-Key branch October 4, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants