Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGS-6127] Add support for flush_runtime and flush_group #405

Merged
merged 13 commits into from
May 8, 2023

Conversation

jspellman814
Copy link

Addresses #399.

@jspellman814 jspellman814 requested review from a team as code owners May 1, 2023 20:39
@jspellman814 jspellman814 marked this pull request as ready for review May 3, 2023 14:13
@pwtyler
Copy link
Member

pwtyler commented May 4, 2023

@jspellman814 this closes #366 as well, correct?

Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests included.

@jspellman814 jspellman814 requested a review from pwtyler May 5, 2023 22:39
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jspellman814, I bumped the minor version number per the new policy in CONTRIBUTING.md, please make sure I caught all instances and you're onboard with the change.

Makes me think perhaps we should use the same in the changelog headings as well (instead of ### Latest ###), but that's a conversation for elsewhere.

@jspellman814 jspellman814 requested review from pwtyler and a team May 8, 2023 14:03
@jspellman814 jspellman814 merged commit 009f716 into develop May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants