fix - GCP rules - AttributeError (#1210)

* fix - GCP rules - AttributeError * fix - GCP rules - AttributeError - linter fix
panther-labs · Apr 23, 2024 · 9239b29 · 9239b29
1 parent 3fde677
commit 9239b29
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/rules/gcp_audit_rules/gcp_cloudbuild_potential_privilege_escalation.py b/rules/gcp_audit_rules/gcp_cloudbuild_potential_privilege_escalation.py
@@ -3,7 +3,9 @@
 
 
 def rule(event):
-    if not deep_get(event, "protoPayload", "methodName").endswith("CloudBuild.CreateBuild"):
+    if not deep_get(event, "protoPayload", "methodName", default="METHOD_NOT_FOUND").endswith(
+        "CloudBuild.CreateBuild"
+    ):
         return False
 
     authorization_info = deep_walk(event, "protoPayload", "authorizationInfo")

diff --git a/rules/gcp_audit_rules/gcp_serviceusage_apikeys_create_privilege_escalation.py b/rules/gcp_audit_rules/gcp_serviceusage_apikeys_create_privilege_escalation.py
@@ -3,7 +3,9 @@
 
 
 def rule(event):
-    if not deep_get(event, "protoPayload", "methodName").endswith("ApiKeys.CreateKey"):
+    if not deep_get(event, "protoPayload", "methodName", default="METHOD_NOT_FOUND").endswith(
+        "ApiKeys.CreateKey"
+    ):
         return False
 
     authorization_info = deep_walk(event, "protoPayload", "authorizationInfo")