Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okta rate limit tuning #1329

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Okta rate limit tuning #1329

merged 4 commits into from
Aug 19, 2024

Conversation

arielkr256
Copy link
Contributor

Background

Rate limits are noisy and rarely actionable. This rule was always triggering duplicates for rate limit warnings followed by violations.

Changes

  • Only alert on rate limit violations
  • Lower severity
  • Higher dedup interval

Testing

  • make test

@arielkr256 arielkr256 requested a review from a team as a code owner August 19, 2024 15:28
Copy link

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@ben-githubs ben-githubs merged commit 790b4e5 into release Aug 19, 2024
6 checks passed
@ben-githubs ben-githubs deleted the okta-rate-limit-tuning branch August 19, 2024 17:31
arielkr256 added a commit that referenced this pull request Aug 22, 2024
* updated okta rate limit rules

* only alert on rate limit violations

---------

Co-authored-by: ben-githubs <38414634+ben-githubs@users.noreply.github.com>
@arielkr256 arielkr256 added the tuning detection tuning label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tuning detection tuning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants