Fix Unit Tests Failing in Pypanther #1335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
pypanther
's testing suite always runs the auxiliiary functions (title
,dedup
,alert_context
, etc.) regardless of whether the unit test is expected to return True or False. This is different from PAT's behaviour, where those functions only run when the unit test hasExpectedResult=True
. Due to this expectation, some rules have auxilliary functions designed in a way where they don't execute properly for all test logs. This PR addresses the problem with 2 of our rules.Changes
Testing
pypanther