Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pack Manifests with Data Models and Globals #1342

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

ben-githubs
Copy link
Contributor

Background

Some of the detections used in packs are generic (i.e. they can be used for other log types, and the use data models to do so). In such cases, the unit tests will fail if the data models for those log types aren't present. Additionally, some packs were missing global helpers (either because a new rule was added, or because the top-level helper was included in the pack, but it's dependencies weren't.)

For CI/CD users, these changes are moot, since they always upload the full repo, but for Console users, this can lead to missing dependencies when enabling packs.

For more information, see this ticket in #ask.

Changes

  • If a rule in a pack can be used for a certain log type, the data model for that log type is added to the pack
  • Added additional helpers as needed by each pack

Testing

  • Wrote a script to look for missing pack items, and spot checked the findings. Looked good!

@ben-githubs ben-githubs requested a review from a team as a code owner September 3, 2024 21:49
Copy link

github-actions bot commented Sep 3, 2024

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@arielkr256 arielkr256 added the bug Something isn't working label Sep 4, 2024
@arielkr256 arielkr256 enabled auto-merge (squash) September 4, 2024 16:25
@arielkr256 arielkr256 merged commit d195f9d into release Sep 4, 2024
6 checks passed
@arielkr256 arielkr256 deleted the ben/put-datamodels-in-packs branch September 4, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants