Update Pack Manifests with Data Models and Globals #1342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Some of the detections used in packs are generic (i.e. they can be used for other log types, and the use data models to do so). In such cases, the unit tests will fail if the data models for those log types aren't present. Additionally, some packs were missing global helpers (either because a new rule was added, or because the top-level helper was included in the pack, but it's dependencies weren't.)
For CI/CD users, these changes are moot, since they always upload the full repo, but for Console users, this can lead to missing dependencies when enabling packs.
For more information, see this ticket in #ask.
Changes
Testing