Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make check-packs action work #1427

Merged
merged 11 commits into from
Nov 13, 2024
Merged

Conversation

ben-githubs
Copy link
Contributor

@ben-githubs ben-githubs commented Nov 12, 2024

Background

There are some issues with the check-packs action, including:

  • it always returns successful, even when there are actually issues with packs
  • it always adds a "😱 looks like some things could be wrong with the packs!" comment, even when there are no things wrong with the packs
  • it never deletes the above comment, even when the problem is resolved

This PR fixes this, so that the comment is only present when pack issues exist, and the action will fail if there are issues with the packs. This will allow us to catch pack issues in the PR phase, as God intended, and not after the fact.

Changes

  • update the GHA comment dependency to v3 so that it actually works
  • separate the "get check-packs output" and "get check-packs exit code" logic into 2 separate steps, to allow accurate job status reporting

Testing

  • Look at all my test commits. I have made sure it works by live testing in Github. I have seen the beginning and the end and I am left but a husk of a man for it.

@ben-githubs ben-githubs marked this pull request as ready for review November 12, 2024 20:20
@ben-githubs ben-githubs requested a review from a team as a code owner November 12, 2024 20:20
@arielkr256 arielkr256 added the github_actions Pull requests that update GitHub Actions code label Nov 13, 2024
@ben-githubs
Copy link
Contributor Author

@arielkr256 this one's good to go!

@arielkr256 arielkr256 enabled auto-merge (squash) November 13, 2024 20:29
@arielkr256 arielkr256 merged commit fe0038e into develop Nov 13, 2024
8 checks passed
@arielkr256 arielkr256 deleted the ben/check-packs-action/fix-comments branch November 13, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants