Update test procedures and README #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhakmiller
requested review from
austinbyers,
jacknagz and
kostaspap
as code owners
austinbyers
approved these changes
Mar 26, 2020
README.md
Outdated
| @@ -233,6 +230,28 @@ The specification file MUST: | |||
| - ResourceTypes | |||
| - Severity | |||
|
|
|||
| ## Testing | |||
| Both policies and tests can define unit tests, which can be used to ensure they are performing as expected on test data before pushing them live to a production environment. This can help guarantee correctness of code, as well as protect against exceptions and unexpected behavior. To run these tests, consider using the `panther_analysis_tool` directly or making use of the `Makefile` provided here. For using the `panther_analysis_tool` directly, please refer to the [documentation](https://github.com/panther-labs/panther_analysis_tool). | |||
There was a problem hiding this comment.
Both policies and rules?
lindsey-w
pushed a commit
that referenced
this pull request
Sep 24, 2020
egibs
pushed a commit
that referenced
this pull request
Jan 16, 2024
arielkr256
added a commit
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Previously the
make testcommand did not work if any policies or rules actually made use of theaws_globalsfile. This is because of the way thepanther_analysis_toolwas being used, it expects to find all files under one root directory and we were not testing it in that way. I've update the Makefile to work first copy all policies/rules into a temporary directory, then run thepanther_analysis_toolagainst that directory.Changes
make testtargetTesting
make test