Kbroughton/make lint action #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbroughton
requested review from
nhakmiller,
lindsey-w,
wey-chiang,
kostaspap and
k-bailey
as code owners
|
Agree this is not ideal. Syncing internally with the team. |
edyesed
approved these changes
Aug 5, 2022
kbroughton
added a commit
to kbroughton/panther-analysis
that referenced
this pull request
Aug 19, 2022
…n/panther-analysis into k8s-unauthorized-exec-into-pod * 'k8s-unauthorized-exec-into-pod' of github.com:kbroughton/panther-analysis: (21 commits) fix: greynoise object function call not attribute (panther-labs#479) Packs: Cloudflare & Slack (panther-labs#478) feat: bring additional alert_context to AWS rules which had none (panther-labs#472) feat: cyclomatic complexity linting (panther-labs#474) Tweak - Cloudflare L7 DDoS (panther-labs#475) chore: update test badge to use github actions (panther-labs#471) Combine GSuite High/Medium/Low Rule alerts into one (panther-labs#467) kbailey: remove circleCI (panther-labs#470) Kbroughton/make lint action (panther-labs#452) fix: panther specific github actions should not run on forks (panther-labs#469) Remove managed schemas (panther-labs#421) Slack Detections - User (panther-labs#464) Slack Detections - EKM (panther-labs#463) Slack Detections - App (panther-labs#462) Initial Commit - Slack Detections - File (panther-labs#465) Slack Detections - Channel (panther-labs#461) Slack Detections - Workspace/Org (panther-labs#460) Update GSuite Alerts Rules with Rule Name (panther-labs#440) Add example lookup table and data file (panther-labs#446) Slack Data Models & Alert Context Helper (panther-labs#458) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Panther currently has two github actions in .github/workflows
Both of these require Panther specific secrets and have to be disabled manually when the repo is forked.
On the other hand, every time I submit a PR, it fails the linting check from a circle-ci plugin.
lint.yml as a github action would make it much easier to make PRs that work the first time.
Changes
add .github/workflows/lint.yml
Testing
Tested locally using nektos/act and with pushes to forked repos.