Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix p_any_ip_address -> p_any_ip_addresses #518

Merged
merged 1 commit into from
Sep 27, 2022
Merged

bugfix p_any_ip_address -> p_any_ip_addresses #518

merged 1 commit into from
Sep 27, 2022

Conversation

calkim-panther
Copy link
Contributor

@calkim-panther calkim-panther commented Sep 27, 2022 •
edited
Loading

Background

Bug: GCP rules used p_any_ip_address instead of p_any_ip_addresses in summary field

Changes

Updated incorrect names

Testing

@calkim-panther calkim-panther requested review from a team September 27, 2022 20:11
edyesed
edyesed approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@edyesed edyesed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change updates the gcp_audit_rules to use p_any_ip_addresses instead of p_any_ip_address 👍

@calkim-panther calkim-panther merged commit 3f89216 into master Sep 27, 2022
@calkim-panther calkim-panther deleted the 1775-bugfix branch September 27, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edyesed edyesed edyesed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calkim-panther @edyesed