Update aws_unauthorized_api_call dedup function #932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Customers were running into empty
dedup
values because thededup
function for this rule is looking for anarn
key in theuserIdentity
object which does not exist (based on the test logs, this used to be a valid key and was likely removed).This PR updates the
dedup
function to useprincipalId
instead.Changes
principalId
key rather than the nonexistentarn
keyTesting