Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added MITRE ATT&CK tags to all Slack rules #933

Merged
merged 6 commits into from
Nov 9, 2023
Merged

added MITRE ATT&CK tags to all Slack rules #933

merged 6 commits into from
Nov 9, 2023

Conversation

arielkr256
Copy link
Contributor

Background

Slack rules have the highest volume of critical and high alerts among rules without MITRE ATT&CK tags.

Changes

  • Added MITRE tactic and technique friendly names to Tags and MITRE tactic:technique codes to Reports: MITRE ATT&CK

Testing

  • Metadata changes only

@arielkr256 arielkr256 requested a review from a team November 8, 2023 20:50
egibs
egibs reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@egibs egibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM; I just had a few clarifying questions.

rules/slack_rules/slack_app_added.yml Outdated Show resolved Hide resolved
rules/slack_rules/slack_private_channel_made_public.yml Show resolved Hide resolved
rules/slack_rules/slack_service_owner_transferred.yml Show resolved Hide resolved
@arielkr256 arielkr256 merged commit 6fc2751 into main Nov 9, 2023
1 check passed
@arielkr256 arielkr256 deleted the slack-rule-mitre-tags branch November 9, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egibs egibs egibs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielkr256 @egibs