Add EXCLUDED_BUCKET_NAMES set for aws_cloudtrail_s3_bucket_public.py policy #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egibs
changed the title
grantjoy
previously approved these changes
Nov 16, 2023
arielkr256
reviewed
Nov 16, 2023
grantjoy
approved these changes
Nov 16, 2023
egibs
deleted the
egibs-add-excluded-buckets-to-s3-bucket-public-policy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The Events
codepipeline-cloudtrail-placeholder-bucketBuckets are managed by AWS and are also public. This was causing theaws_cloudtrail_s3_bucket_publicpolicy to alert when the buckets were inspected.This PR adds an
EXCLUDED_BUCKET_NAMESset for these buckets (and future buckets, if necessary) and also adds a list of AWS regions in order to build out the complete set of these bucket names.Changes
EXCLUDED_BUCKET_NAMESset for buckets to ignore in the policyTesting