Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA release pipeline #226

Closed
wants to merge 5 commits into from
Closed

GHA release pipeline #226

wants to merge 5 commits into from

Conversation

maxrichie5
Copy link
Contributor

@maxrichie5 maxrichie5 commented Nov 4, 2022 •
edited
Loading

Background

We currently have to manually release PAT from our local machines. This creates a github workflow to release it.

Please note that the pypi password has NOT been added to the repo yet, waiting until team approves of this

Changes

  • Adds release workflow to release changes when merged to master branch
  • Cleans up ci workflow
  • Cleans up makefile
  • Updates version logic to match what mypy does
  • Updates version of black (LOTS of changes because I ran make fmt)

Testing

  • Ran the test dist steps locally

@maxrichie5 maxrichie5 requested review from a team November 4, 2022 18:34
cdzombak
cdzombak previously approved these changes Nov 4, 2022
View reviewed changes
darwayne
darwayne reviewed Nov 4, 2022
View reviewed changes
setup.py Show resolved Hide resolved
darwayne
darwayne reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor

@darwayne darwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool stuff, curious as to what the new workflow will be with this change ... every PR change we need to bump the version.py file? .. if we forget will CI fail? (that'd be awesome)

darwayne
darwayne previously approved these changes Nov 4, 2022
View reviewed changes
@maxrichie5 maxrichie5 dismissed stale reviews from darwayne and cdzombak via 9fedc32 November 5, 2022 19:15
@maxrichie5 maxrichie5 marked this pull request as draft November 7, 2022 15:15
@maxrichie5 maxrichie5 removed the request for review from a team November 7, 2022 15:16
@grantjoy
Copy link
Contributor

@maxrichie5 is there a reason this didn't merge after @darwayne approved it?

@grantjoy grantjoy changed the title maxrichmond: release pipeline GHA release pipeline Oct 20, 2023
@maxrichie5
Copy link
Contributor Author

@maxrichie5 is there a reason this didn't merge after @darwayne approved it?

Umm. Maybe the secret mentioned in the desc? I honestly don't remember

@grantjoy
Copy link
Contributor

closing as it's been implemented in #390

@grantjoy grantjoy closed this Oct 24, 2023
@le4ker le4ker deleted the maxrichmond-release-pipeline branch January 29, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darwayne darwayne darwayne approved these changes

@cdzombak cdzombak cdzombak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxrichie5 @grantjoy @cdzombak @darwayne