Performance improvement for large data #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # include/inja/renderer.hpp # single_include/inja/inja.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation performs a deep copy of
Renderer::m_dataevery time there is a loop statement in the template. This copying becomes a significant overhead with large input data and complex templates.This change introduces
Renderer::m_loop_datawhich is used to track the loop context and avoids the deep copy.The updated benchmark shows no difference in performance between the small and large input data. If this benchmark is run against the original code, rendering the large data takes 10x longer than the small data. In real-world scenarios I have observed up to 75x performance improvement with this change.