Add support for setting subobjects via JSON pointer in set statements. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. `{% set x.y = 1 %}` sets the `y` member of `x` to 1.
|
LGTM. Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for JSON pointers to set statements, e.g.
{% set x.y = 1 %}sets theymember ofxto 1.Previously, you could use JSON pointer syntax in a set statement, but it did not work as you might expect.
{% set x.y = 1 %}would render without errors, but{{ x.y }}would not be set to 1.Tests are included. In addition to adding tests for set statements with JSON pointers, I also added tests for setting variables that are in the original JSON data, as such tests seemed to be missing.
I also updated the
README.mdsection to explain that JSON pointers work to set sub-objects and that the set statement will not modify the underlying JSON object you pass in to arendercall.