Skip to content

Commit

Permalink
fix the last couple tests
Browse files Browse the repository at this point in the history
  • Loading branch information
cosmicexplorer committed Nov 29, 2018
1 parent e198d76 commit 29a3d0e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def _assert_ctypes_interop_with_mock_buildroot(self, toolchain_variant):
build_root=buildroot.new_buildroot)
self.assert_failure(pants_binary_strict_deps_failure)
self.assertIn(self._include_not_found_message_for_variant[toolchain_variant],
pants_binary_strict_deps_failure.stdout_dMata)
pants_binary_strict_deps_failure.stdout_data)

# TODO(#???): we need to provide the libstdc++.so.6.dylib which comes with gcc on osx in the
# DYLD_LIBRARY_PATH during the 'run' goal somehow.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ def _create_distribution_synthetic_target(self, python_dist_target, extra_target
for_subsystems=[PythonRepos, LibcDev],
# TODO(#???): we should be testing all of these with both of our toolchains.
options={
'libc-dev': {
'enable_libc_search': True,
'native-build-settings': {
'toolchain_variant': 'llvm',
},
})
self.assertEqual(set(self._all_specified_targets()), set(context.build_graph.targets()))
Expand Down

0 comments on commit 29a3d0e

Please sign in to comment.