Skip to content

Commit

Permalink
fix gigantic Params
Browse files Browse the repository at this point in the history
[ci skip-build-wheels]
  • Loading branch information
gshuflin committed Aug 19, 2020
1 parent de7d5c3 commit 4a6160a
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/rust/engine/src/nodes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,11 @@ impl Display for NodeKey {
&NodeKey::Scandir(ref s) => write!(f, "Scandir({})", (s.0).0.display()),
&NodeKey::Select(ref s) => write!(f, "{}", s.product),
&NodeKey::Task(ref task) => {
write!(f, "@rule {}({})", task.task.display_info.name, task.params)
//TODO cf. https://github.com/pantsbuild/pants/issues/7907 , we probably
//want to include some kind of representation of the Params of an @rule when
//we stringify the @rule. But we need to make sure we don't naively dump
//the string representation of a Key, which could get gigantic.
write!(f, "@rule {}", task.task.display_info.name)
}
&NodeKey::Snapshot(ref s) => write!(f, "Snapshot({})", s.0),
}
Expand Down

0 comments on commit 4a6160a

Please sign in to comment.