Skip to content

Commit

Permalink
add TODO links
Browse files Browse the repository at this point in the history
  • Loading branch information
cosmicexplorer committed Dec 5, 2018
1 parent 5473093 commit 55e6908
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/python/pants/backend/native/subsystems/binaries/gcc.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def _cpp_include_dirs(self):
('include/c++', self.version()),
])

# TODO: determine whether there is any manual explaining when any of these file paths are
# TODO(#6143): determine whether there is any manual explaining when any of these file paths are
# necessary.
# This file is needed for C++ compilation.
cpp_config_header_path = self._file_mapper.assert_single_path_by_glob(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def _assert_ctypes_binary(self, toolchain_variant):

# Check that we have selected the appropriate compilers for our selected toolchain variant,
# for both C and C++ compilation.
# TODO(#6866): don't parse info logs for testing!
for compiler_name in self._compiler_names_for_variant[toolchain_variant]:
self.assertIn("selected compiler exe name: '{}'".format(compiler_name),
pants_run.stdout_data)
Expand Down

0 comments on commit 55e6908

Please sign in to comment.