Remove deprecated 2.16.0.dev0.

pantsbuild · Nov 19, 2022 · 5cf20ae · 5cf20ae
1 parent 1e131d6
commit 5cf20ae
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 72 deletions.
diff --git a/src/python/pants/backend/python/subsystems/poetry.py b/src/python/pants/backend/python/subsystems/poetry.py
diff --git a/src/python/pants/base/specs.py b/src/python/pants/base/specs.py
@@ -10,7 +10,6 @@
 
 from typing_extensions import Protocol
 
-from pants.base.deprecated import warn_or_error
 from pants.base.glob_match_error_behavior import GlobMatchErrorBehavior
 from pants.engine.fs import GlobExpansionConjunction, PathGlobs
 from pants.util.dirutil import fast_relpath_optional, recursive_dirname
@@ -257,7 +256,6 @@ def create(
         specs: Iterable[Spec],
         *,
         description_of_origin: str,
-        convert_dir_literal_to_address_literal: bool | None = None,
         unmatched_glob_behavior: GlobMatchErrorBehavior = GlobMatchErrorBehavior.error,
         filter_by_global_options: bool = False,
         from_change_detection: bool = False,
@@ -267,12 +265,6 @@ def create(
         If the `Spec` objects are already separated by type, prefer using the class's constructor
         directly.
         """
-        if convert_dir_literal_to_address_literal is not None:
-            warn_or_error(
-                "2.16.0.dev0",
-                "the convert_dir_literal_to_address_literal kwarg for `RawSpecs.parse_specs",
-                "Directories are now never converted to AddressLiteral. So, remove the kwarg.",
-            )
 
         address_literals = []
         file_literals = []

diff --git a/src/python/pants/base/specs_parser.py b/src/python/pants/base/specs_parser.py
@@ -8,7 +8,6 @@
 from typing import Iterable
 
 from pants.base.build_environment import get_buildroot
-from pants.base.deprecated import warn_or_error
 from pants.base.glob_match_error_behavior import GlobMatchErrorBehavior
 from pants.base.specs import (
     AddressLiteralSpec,
@@ -117,15 +116,8 @@ def parse_specs(
         specs: Iterable[str],
         *,
         description_of_origin: str,
-        convert_dir_literal_to_address_literal: bool | None = None,
         unmatched_glob_behavior: GlobMatchErrorBehavior = GlobMatchErrorBehavior.error,
     ) -> Specs:
-        if convert_dir_literal_to_address_literal is not None:
-            warn_or_error(
-                "2.16.0.dev0",
-                "the convert_dir_literal_to_address_literal kwarg for `SpecsParser.parse_specs",
-                "Directories are now never converted to AddressLiteral. So, remove the kwarg.",
-            )
         include_specs = []
         ignore_specs = []
         for spec_str in specs:

diff --git a/src/python/pants/engine/process.py b/src/python/pants/engine/process.py
@@ -9,7 +9,6 @@
 from enum import Enum
 from typing import Iterable, Mapping
 
-from pants.base.deprecated import warn_or_error
 from pants.engine.engine_aware import SideEffecting
 from pants.engine.fs import EMPTY_DIGEST, Digest, FileDigest
 from pants.engine.internals.native_engine import (  # noqa: F401
@@ -22,7 +21,6 @@
 from pants.util.frozendict import FrozenDict
 from pants.util.logging import LogLevel
 from pants.util.meta import frozen_after_init
-from pants.util.strutil import softwrap
 
 logger = logging.getLogger(__name__)
 
@@ -88,7 +86,6 @@ def __init__(
         execution_slot_variable: str | None = None,
         concurrency_available: int = 0,
         cache_scope: ProcessCacheScope = ProcessCacheScope.SUCCESSFUL,
-        platform: Platform | None = None,
         remote_cache_speculation_delay_millis: int = 0,
     ) -> None:
         """Request to run a subprocess, similar to subprocess.Popen.
@@ -138,18 +135,6 @@ def __init__(
         self.cache_scope = cache_scope
         self.remote_cache_speculation_delay_millis = remote_cache_speculation_delay_millis
 
-        if platform is not None:
-            warn_or_error(
-                "2.16.0.dev0",
-                "the `platform` kwarg for `Process`",
-                softwrap(
-                    """
-                    The `platform` kwarg no longer does anything because the `platform` is always
-                    automatically set. To fix this deprecation, delete the kwarg.
-                    """
-                ),
-            )
-
 
 @dataclass(frozen=True)
 class ProcessResult: